-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation page and banner to new users #113
Conversation
import RepositoriesTable from './RepositoriesTable'; | ||
|
||
export const OrganizationSheet = () => { | ||
const [showBanner, setShowBanner] = useLocalStorage('show-banner', false); | ||
const isSSR = useSSR(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to perform an SSR check here because next doesn't like when it doesn't have access to things that modify the initial hydration on the client. In this case -> rendering a banner when we finally have access to localStorage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks great to me! I left a couple of suggestions for wording on the documentation, and my best suggestion for copy in the banner.
who-metrics-ui/src/docs/index.md
Outdated
@@ -0,0 +1,7 @@ | |||
# Dangerously |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be removed?
Co-authored-by: Ian Candy <[email protected]>
Co-authored-by: Ian Candy <[email protected]>
Co-authored-by: Ian Candy <[email protected]>
Co-authored-by: Ian Candy <[email protected]>
Co-authored-by: Ian Candy <[email protected]>
This adds a page for documentation that is rendered from a markdown file.
This also adds a new banned to the homepage that still needs some wording suggestions.
The routing for documentation will be updated in a follow-up PR.