Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull_request for next build #105

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Add pull_request for next build #105

merged 2 commits into from
Mar 6, 2024

Conversation

ipc103
Copy link
Collaborator

@ipc103 ipc103 commented Mar 6, 2024

We don't have any tests at all at the moment :grimace:
But at least we can make sure PRs don't totally break the build...

We don't have any tests at all at the moment :grimace:
But at least we can make sure PRs don't totally break the build...
@ipc103 ipc103 requested review from ajhenry and Lehcar March 6, 2024 16:42
@ipc103
Copy link
Collaborator Author

ipc103 commented Mar 6, 2024

Hmm, this didn't run on this PR as I expected it would. Did I get my syntax wrong, or will this not actually run on PRs until this change is merged?

@ajhenry
Copy link
Collaborator

ajhenry commented Mar 6, 2024

Think it has to be merged?

@ipc103
Copy link
Collaborator Author

ipc103 commented Mar 6, 2024

I'll merge and we'll see how it works!

@ipc103 ipc103 merged commit 24714e0 into main Mar 6, 2024
3 checks passed
@ipc103 ipc103 deleted the build-on-pr branch March 6, 2024 20:08
@ipc103 ipc103 mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants