Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the graphql-ruby minimum supported version to 1.13.0 #9

Conversation

Samsinite
Copy link
Contributor

As requested, this commit updates the graphql-ruby testing matrix to include ~1.13.0, ~2.0.0, ~2.1.0 and ~2.2.0. I excluded ~1.12.0 due to failing the CI tests when it was included in the matrix, and specified 1.13.0 as the minimum supported version in the gemspec.

For reference, the ~1.12.0 failure was:

/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/graphql-1.12.24/lib/graphql/schema/argument.rb:55:in `initialize': missing keyword: :required (ArgumentError)
	from /opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/graphql-1.12.24/lib/graphql/schema/member/accepts_definition.rb:142:in `initialize'
	from /opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/graphql-1.12.24/lib/graphql/schema/member/has_arguments.rb:38:in `new'
	from /opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/graphql-1.12.24/lib/graphql/schema/member/has_arguments.rb:38:in `argument'
	from /opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/graphql-1.12.24/lib/graphql/schema/input_object.rb:124:in `argument'
	from /home/runner/work/graphql-client/graphql-client/test/test_schema.rb:20:in `<class:NodeArgInput>'
	from /home/runner/work/graphql-client/graphql-client/test/test_schema.rb:18:in `<class:TestSchemaType>'
	from /home/runner/work/graphql-client/graphql-client/test/test_schema.rb:7:in `<top (required)>'

@rmosolgo
Copy link
Collaborator

rmosolgo commented Feb 2, 2024

Awesome, thank you!

@rmosolgo rmosolgo merged commit e850ae2 into github-community-projects:master Feb 2, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants