feat: Enable consumers to access the full response payload #43
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billybonks
force-pushed
the
feat/access-full-response
branch
from
202b5be to
0d3af67
Compare
Update the Response public API object to include full_response. this is non-breaking. Passing the full response from the executing object to the client is currently done via the client checking with the object, versus it being part of the response, In order to change this it requires changing the much more changes, as all the tests are using GraphQL::Schema for the execution of the graphql
billybonks
force-pushed
the
feat/access-full-response
branch
from
0d3af67 to
1d42e19
Compare
|
Hey, thanks for this contribution! It looks good to me. |
rmosolgo
reviewed
Nov 13, 2024
|
🚢 In 0.24.0! Thanks again. |
|
My pleasure thanks for the swift review and easy contribution :) |
|
Hi, thanks for this, this was actually very important for a use case that we had and we were considering implementing these changes. That said, it is very confusing that the new method named Is this the actual intended behavior? I would believe that such would have the newly exposed method called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Response public API object to include full_response. this is non-breaking.
Passing the full response from the executing object to the client is currently done via the client checking with the object, versus it being part of the response,
In order to change this it requires changing the much more changes, as all the tests are using GraphQL::Schema for the execution of the graphql