Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the deprecation warnings from the logger #10

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions lib/graphql/client/log_subscriber.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,18 @@ class Client
# GraphQL::Client::LogSubscriber.attach_to :graphql
#
class LogSubscriber < ActiveSupport::LogSubscriber
SHOULD_USE_KWARGS = private_instance_methods.include?(:mode_from)

def query(event)
logger.info do
name = event.payload[:operation_name].gsub("__", "::")
type = event.payload[:operation_type].upcase
color("#{name} #{type} (#{event.duration.round(1)}ms)", nil, true)

if SHOULD_USE_KWARGS
color("#{name} #{type} (#{event.duration.round(1)}ms)", nil, bold: true)
else
color("#{name} #{type} (#{event.duration.round(1)}ms)", nil, true)
end
end

logger.debug do
Expand All @@ -32,7 +39,12 @@ def error(event)
logger.error do
name = event.payload[:operation_name].gsub("__", "::")
message = event.payload[:message]
color("#{name} ERROR: #{message}", nil, true)

if SHOULD_USE_KWARGS
color("#{name} ERROR: #{message}", nil, bold: true)
else
color("#{name} ERROR: #{message}", nil, true)
end
end
end
end
Expand Down