[Refactor] SummaryUtil 리팩토링(#723) #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
previously approved these changes
Oct 6, 2024
| expect(result[0].summary.content.message).toBe("Initial commit"); | ||
| }); | ||
|
|
||
| test("클러스터의 커밋 작성자 이름이 중복되지 않는다.", () => { |
There was a problem hiding this comment.
code는 가급적 한글보다는 영어로 작성해주시면 감사하겠습니다!
Comment on lines
98
to
102
| const isUnique = result | ||
| .map((data) => data.summary.authorNames.length === new Set(data.summary.authorNames).size) | ||
| .every((value) => value === true); | ||
|
|
||
| expect(isUnique).toBe(true); |
There was a problem hiding this comment.
이 부분이 정말 아리까리 하네요.
- 일단 test에 logic이 들어가있어서, 이 isUnique에 대한 test가 또 필요할 것 같아요.
- test에는 가급적 value로 정해주면 좋겠습니다.
- 그리고, 하나의 action(result값)에 대한 assertion만 따로 해서 분리를 했는데, 이럴꺼면 getInitData test에 통합시키는게 맞을 것 같긴 합니다.
| // set names | ||
| const authorSet: Set<string> = new Set(); | ||
| commitNode.commit.author.names.map((name) => { | ||
| commitNode.commit.author.names.forEach((name) => { |
This was referenced Oct 6, 2024
|
@pithesun 님, |
|
넵 수정해서 오늘중으로 머지하겠습니다!😄 |
pithesun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#723
Result
getInitData 의 주요 역할이
로 보았는데, 1번에 대한 테스트코드를 추가해보았습니다.
Work list
Discussion