Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (bank-sdk) Add possibility to terminate bank-sdk from outer app #624

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: (bank-sdk) Add possibility to terminate bank-sdk from outer app #624

wants to merge 2 commits into from

Conversation

GeraltRiv
Copy link
Contributor

PM-127

llevente
llevente requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@llevente llevente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks okay. Only a small documentation typo needs to be fixed.

bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/GiniBank.kt Outdated

/**
*
* Kills Bank sdk and stos Gini payment flow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo at "stops"

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llevente llevente llevente requested changes

@abolfazlimahdi abolfazlimahdi Awaiting requested review from abolfazlimahdi

@obaidgini obaidgini Awaiting requested review from obaidgini

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeraltRiv @llevente