Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(bank-sdk): Skonto + RA validation implementation #618

Merged
merged 30 commits into from
Dec 3, 2024

Conversation

ndubkov-distcotech
Copy link
Contributor

PP-795

Copy link
Contributor

@abolfazlimahdi abolfazlimahdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. The behavior is not as it was intended. The validation error show for a moment and then disappears. It should disappear with a user's action. Thank you!

@ndubkov-distcotech ndubkov-distcotech changed the base branch from PP-763-skonto-validation to PP-763-skonto-validation-mvi-orbit November 18, 2024 14:03
@ndubkov-distcotech ndubkov-distcotech marked this pull request as ready for review November 18, 2024 14:03
Copy link
Contributor

@abolfazlimahdi abolfazlimahdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

Copy link

sonarcloud bot commented Dec 3, 2024

@ndubkov-distcotech ndubkov-distcotech changed the base branch from PP-763-skonto-validation-mvi-orbit to main December 3, 2024 12:38
@ndubkov-distcotech ndubkov-distcotech merged commit 029551d into main Dec 3, 2024
152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants