Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added automation for Digital Invoice Screen #565

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Added automation for Digital Invoice Screen #565

merged 6 commits into from
Sep 18, 2024

Conversation

SyedaGinii
Copy link

@SyedaGinii SyedaGinii commented Sep 9, 2024 •
edited
Loading

Ui Automation for Digital Invoice Screen
Jira ticket: https://ginis.atlassian.net/browse/PM-26

@SyedaGinii SyedaGinii requested a review from danicretu September 9, 2024 08:27
@SyedaGinii SyedaGinii changed the base branch from main to test-automation September 9, 2024 13:02
danicretu
danicretu requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @SyedaGinii, thanks for implementing these test cases, they will prove very valuable to track any changes in the implementation of the digital invoice screen!

I left some change requests to clarify what the aims of the tests cases are, and to return and use the results of the checks you perform.

.../src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/ConfigurationScreen.kt Outdated Show resolved Hide resolved
.../src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/ConfigurationScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
danicretu
danicretu requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for applying the modifications! It looks much better now 😄

Sorry to request more changes, it's very important to check that the application behaves as we intend it to...

I've added a few requests that will hopefully help achieve the results we want from the testcases.

...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
@SyedaGinii SyedaGinii changed the title Automation(digital invoice screen) Added automation for Digital Invoice Screen Sep 13, 2024
danicretu
danicretu requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Syeda! The test cases look a lot better! I added some clarifications and suggestions to some of the functions, to ensure we make the most of the test cases

...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/DigitalInvoiceScreen.kt Outdated Show resolved Hide resolved
...app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/ExtractionScreen.kt Show resolved Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/MainScreen.kt Outdated Show resolved Hide resolved
@danicretu danicretu mentioned this pull request Sep 16, 2024
Merged
danicretu
danicretu requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the latest modifications! As discussed on Slack, please assert the remaining checks, so that we ensure the tests fail if the desired behaviour is changed.

...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Outdated Show resolved Hide resolved
...roidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/DigitalInvoiceScreenTests.kt Show resolved Hide resolved
danicretu
danicretu approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience Syeda! Good work! 💯

@SyedaGinii SyedaGinii merged commit 4d30565 into test-automation Sep 18, 2024
7 of 8 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zladzeyka zladzeyka deleted the automation(digital-invoice-screen) branch September 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danicretu danicretu danicretu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyedaGinii @danicretu