Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ec 87 merchant sdk documentation #537

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Ec 87 merchant sdk documentation #537

merged 11 commits into from
Aug 20, 2024

Conversation

danicretu
Copy link
Contributor

No description provided.

@danicretu danicretu requested a review from a-szotyori August 19, 2024 11:06
@danicretu danicretu self-assigned this Aug 19, 2024
a-szotyori
a-szotyori suggested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Daniela! Looks great. I have only some minor comments. Besides the comments I also have these minor things:

  • setup.rst: replace Health API with Merchant API
  • testing.rst: replace Health API with Merchant API

merchant-sdk/sdk/src/doc/source/index.rst Outdated Show resolved Hide resolved
merchant-sdk/sdk/src/doc/source/authentication.rst Outdated Show resolved Hide resolved
merchant-sdk/sdk/src/doc/source/flow.rst Outdated Show resolved Hide resolved
merchant-sdk/sdk/src/doc/source/event-tracking.rst Outdated Show resolved Hide resolved
merchant-sdk/sdk/src/doc/source/event-tracking.rst Outdated Show resolved Hide resolved
merchant-sdk/sdk/src/doc/source/event-tracking.rst Outdated Show resolved Hide resolved
merchant-sdk/sdk/src/doc/source/event-tracking.rst Outdated Show resolved Hide resolved
merchant-sdk/sdk/src/doc/source/event-tracking.rst Outdated Show resolved Hide resolved
a-szotyori
a-szotyori suggested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have just two minor things left. Besides my comment please also add a vertical line | above the Payment Review Screen header to add a blank line above the header:
Screenshot 2024-08-20 at 11 01 49

merchant-sdk/sdk/src/doc/source/customization.rst Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

a-szotyori
a-szotyori approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@danicretu danicretu merged commit 38cbce3 into main Aug 20, 2024
7 checks passed
@a-szotyori a-szotyori deleted the EC-87-Merchant-SDK-documentation branch August 21, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-szotyori a-szotyori a-szotyori approved these changes

Assignees

@danicretu danicretu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danicretu @a-szotyori