Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile-android) Change navigationBar color #516

Merged

Conversation

GeraltRiv
Copy link
Contributor

PP-196

Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being a PITA about commits 🙈 Please rewrite the commit message (it's ok to force push into your own feature branch): we don't use mobile-android as a project name. When multiple projects are affected, then the project has to be omitted. I usually list in the commit body the affected projects. The commit message should then look like this:

fix: Change navigationBar color

Affects: bank-sdk, capture-sdk, health-sdk

PP-196

For the future: what we prefer is to have separate commits in such cases for each modified project to have a dedicated fix(<project>) commit for each one.

The advantage of having the project name in the commit is that in our monorepo we can filter the git history to see what has been changed for each project, for ex. to view all changes for Bank SDK since a particular release: $ git log --oneline --grep="bank-sdk" "bank-sdk;3.12.0..HEAD" --no-merges

git-log.mov

Affects: bank-sdk, capture-sdk, health-sdk
PP-196
@GeraltRiv GeraltRiv force-pushed the PP-196_Make-bottom-status-bar-adapt-to-light-and-dark-modes branch from 147c259 to 3d4c687 Compare August 11, 2024 09:51
@GeraltRiv
Copy link
Contributor Author

Sorry for being a PITA about commits 🙈 Please rewrite the commit message (it's ok to force push into your own feature branch): we don't use mobile-android as a project name. When multiple projects are affected, then the project has to be omitted. I usually list in the commit body the affected projects. The commit message should then look like this:

fix: Change navigationBar color

Affects: bank-sdk, capture-sdk, health-sdk

PP-196

For the future: what we prefer is to have separate commits in such cases for each modified project to have a dedicated fix(<project>) commit for each one.

The advantage of having the project name in the commit is that in our monorepo we can filter the git history to see what has been changed for each project, for ex. to view all changes for Bank SDK since a particular release: $ git log --oneline --grep="bank-sdk" "bank-sdk;3.12.0..HEAD" --no-merges

git-log.mov

Done

Copy link

@GeraltRiv GeraltRiv merged commit 8ed0a56 into main Aug 15, 2024
23 checks passed
@GeraltRiv GeraltRiv deleted the PP-196_Make-bottom-status-bar-adapt-to-light-and-dark-modes branch August 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants