feat(capture-sdk): Use new photo-picker. #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraltRiv
force-pushed
the
PP-198_Implement_new_Android_PhotoPicker
branch
from
8ebdbe0 to
167cae0
Compare
a-szotyori
suggested changes
Jul 11, 2024
There was a problem hiding this comment.
Great work! I have a couple of minor comments.
Please note that we are using comment labels to help prioritise the comments. You can read about them here: https://ginis.atlassian.net/wiki/spaces/PLMO/pages/83722835/Pull+Request+labels+description
...re-sdk/sdk/src/main/java/net/gini/android/capture/internal/fileimport/FileChooserFragment.kt
Outdated
Show resolved
Hide resolved
...re-sdk/sdk/src/main/java/net/gini/android/capture/internal/fileimport/FileChooserFragment.kt
Show resolved
Hide resolved
...main/java/net/gini/android/capture/internal/fileimport/providerchooser/ProvidersAdapter.java
Outdated
Show resolved
Hide resolved
| holder.icon.setImageDrawable(item.getDrawableIcon()); | ||
| holder.label.setText(item.getText()); | ||
| holder.itemView.setOnClickListener(view -> { | ||
| final ProvidersAppWrapperItem item1 = |
There was a problem hiding this comment.
[Suggestion] Same as above.
...re-sdk/sdk/src/main/java/net/gini/android/capture/internal/fileimport/FileChooserFragment.kt
Outdated
Show resolved
Hide resolved
...re-sdk/sdk/src/main/java/net/gini/android/capture/internal/fileimport/FileChooserFragment.kt
Outdated
Show resolved
Hide resolved
GeraltRiv
force-pushed
the
PP-198_Implement_new_Android_PhotoPicker
branch
from
c583579 to
346f713
Compare
|
I updated the target branch to collect this in the |
added 7 commits
July 31, 2024 13:08
Now we are using new photo picker, for devices that doesn't have backdrop version, we use the same approach with list of apps PP-198
Fix switch issue PP-198
Empty list returns with multiply photo choosing PP-198, PM-91
…ment Fix review issues with code naming, and exception throw PP-198
Fix review issues PP-198
Use new photo picker only from API26+ PP-198
GeraltRiv
force-pushed
the
PP-198_Implement_new_Android_PhotoPicker
branch
from
2120422 to
6438cbd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are using new photo picker, for devices that doesn't have backdrop version, we use the same approach with list of apps PM-198