Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp 197 migrate from start activity for result to register for result #484

Conversation

GeraltRiv
Copy link
Contributor

No description provided.

jackkray added 2 commits July 4, 2024 19:55
Remove deprecated startActivityForResult and implement registerForActivityResult

PP-197
@GeraltRiv GeraltRiv requested a review from a-szotyori July 4, 2024 18:04
Copy link

sonarqubecloud bot commented Jul 4, 2024

@a-szotyori a-szotyori requested a review from danicretu July 5, 2024 08:52
Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@GeraltRiv GeraltRiv merged commit 6f572e8 into main Jul 5, 2024
33 checks passed
@a-szotyori
Copy link
Contributor

a-szotyori commented Jul 8, 2024

Hi, @GeraltRiv, I'm sorry for the confusion. I was not explicit enough about our development process. Usually before merging a PR it goes through a testing (QA) phase.

I will revert the merge because the Photopayment team has a release scheduled and we should not accidentally break existing functionality.

Please open a new PR and follow this guide please to upload a Bank SDK example app build to App Center and to add the link to it to the PP-197 ticket. Thank you!

@GeraltRiv
Copy link
Contributor Author

Hi, @GeraltRiv, I'm sorry for the confusion. I was not explicit enough about our development process. Usually before merging a PR it goes through a testing (QA) phase.

I will revert the merge because the Photopayment team has a release scheduled and we should not accidentally break existing functionality.

Please open a new PR and follow this guide please to upload a Bank SDK example app build to App Center and to add the link to it to the PP-197 ticket. Thank you!

Oh, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants