Pia 4595 extract feedback from cleanup #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-szotyori
suggested changes
Oct 16, 2023
There was a problem hiding this comment.
Sorry for the many requests. Most of them are about the documentation.
Please also update the extraction feedback integration tests:
- Rename to
TransferSummaryIntegrationTest - Replace deprecated
cleanup()withsendTransferSummary()andcleanup().
The integration tests can be found here:
- capture-sdk/default-network/src/androidTest/java/net/gini/android/capture/network/ExtractionFeedbackIntegrationTest.kt
- bank-sdk/sdk/src/androidTest/java/net/gini/android/bank/sdk/ExtractionFeedbackIntegrationTest.kt
Thank you!
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java
Outdated
Show resolved
Hide resolved
bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/GiniBank.kt
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java
Outdated
Show resolved
Hide resolved
...sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ExtractionsActivity.kt
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java
Outdated
Show resolved
Hide resolved
abolfazlimahdi
force-pushed
the
PIA-4595-extract-feedback-from-cleanup
branch
2 times, most recently
from
3890d11 to
b6826e6
Compare
zladzeyka
reviewed
Oct 30, 2023
| /** | ||
| * Provides transfer summary to Gini. | ||
| * | ||
| * Please provide the required transfer summary to improve the future extraction accuracy. |
There was a problem hiding this comment.
[Suggestion] we have 4 sentences in row, which are starting from Please. I propose to keep it till Please follow the recommendations below and remove other please after.
There was a problem hiding this comment.
@zladzeyka Just to be on the same page, you mean I delete the pleases after the first one?
…arate methods PIA-4595
…e methods PIA-4595
- rename ExtractionFeedbackIntegrationTest to TransferSummaryIntegrationTest - rename feedback to transfer summary in comments and menu items - add some information about how to use sendTransferSummary method - enhance Kotlin and Java docs PIA-4595
abolfazlimahdi
force-pushed
the
PIA-4595-extract-feedback-from-cleanup
branch
from
b6826e6 to
a32ba46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.