feat(bank-sdk): Improve desgin for main screen

PIA-4446
gini · Sep 14, 2023 · d831ebf · d831ebf
1 parent 2dbd508
commit d831ebf
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 11 deletions.
diff --git a/bank-sdk/example-app/src/main/res/layout/activity_main.xml b/bank-sdk/example-app/src/main/res/layout/activity_main.xml
@@ -24,7 +24,7 @@
                 style="@style/PhotoPaymentButtonStyle"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
-                android:layout_marginTop="@dimen/gc_large_32"
+                android:layout_marginTop="@dimen/gc_large"
                 android:paddingVertical="@dimen/gc_medium_12"
                 android:text="@string/start_gini_photo_payment"
                 app:layout_constraintEnd_toEndOf="parent"
@@ -35,7 +35,7 @@
                 android:id="@+id/iv_giniLogo"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:layout_marginTop="@dimen/gc_large_80"
+                android:layout_marginTop="@dimen/gc_large_64"
                 android:src="@drawable/gini_logo"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
@@ -47,7 +47,7 @@
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
                 android:layout_marginHorizontal="@dimen/gc_large_48"
-                android:layout_marginTop="@dimen/gc_large_20"
+                android:layout_marginTop="@dimen/gc_medium_12"
                 android:gravity="center"
                 android:text="@string/example_of_photo_payment"
                 android:textAlignment="center"
@@ -60,7 +60,7 @@
                 style="@style/Body1Gray"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:layout_marginTop="@dimen/gc_large_32"
+                android:layout_marginTop="@dimen/gc_large"
                 android:text="@string/or_use_label"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
@@ -83,8 +83,7 @@
                 style="@style/GiniCaptureTheme.Typography.Overline"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
-                android:layout_marginTop="@dimen/gc_large_32"
-                android:layout_marginBottom="@dimen/gc_medium_12"
+                android:layout_marginTop="@dimen/gc_large_48"
                 android:gravity="center"
                 android:padding="@dimen/gc_medium"
                 app:layout_constraintBottom_toBottomOf="parent"
@@ -110,8 +109,8 @@
                 <com.google.android.material.textfield.TextInputEditText
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
-                    android:paddingTop="0dp"
-                    android:paddingBottom="0dp"
+                    android:paddingTop="@dimen/gc_medium"
+                    android:paddingBottom="@dimen/gc_medium"
                      />
 
             </com.google.android.material.textfield.TextInputLayout>

diff --git a/bank-sdk/example-app/src/main/res/values-night/styles.xml b/bank-sdk/example-app/src/main/res/values-night/styles.xml
@@ -39,7 +39,7 @@
     </style>
 
     <style name="PhotoPaymentButtonStyle" parent="Widget.Material3.Button">
-        <item name="cornerRadius">8dp</item>
+        <item name="cornerRadius">4dp</item>
         <item name="backgroundTint">@color/gc_dark_04</item>
         <item name="android:textColor">@color/gc_light_01</item>
         <item name="android:textSize">17sp</item>

diff --git a/bank-sdk/example-app/src/main/res/values/dimens.xml b/bank-sdk/example-app/src/main/res/values/dimens.xml
@@ -1,5 +1,19 @@
 <resources>
     <!-- Default screen margins, per the Android Design guidelines. -->
+    <dimen name="gc_small">4dp</dimen>
+    <dimen name="gc_medium">8dp</dimen>
+    <dimen name="gc_medium_12">12dp</dimen>
+    <dimen name="gc_large">16dp</dimen>
+    <dimen name="gc_large_20">20dp</dimen>
+    <dimen name="gc_large_24">24dp</dimen>
+    <dimen name="gc_large_32">32dp</dimen>
+    <dimen name="gc_large_48">48dp</dimen>
+    <dimen name="gc_large_64">64dp</dimen>
+    <dimen name="gc_large_72">72dp</dimen>
+    <dimen name="gc_large_80">80dp</dimen>
+    <dimen name="gc_large_96">96dp</dimen>
+
+
     <dimen name="activity_horizontal_margin">16dp</dimen>
     <dimen name="activity_vertical_margin">16dp</dimen>
     <dimen name="input_spacing">16dp</dimen>

diff --git a/bank-sdk/example-app/src/main/res/values/styles.xml b/bank-sdk/example-app/src/main/res/values/styles.xml
@@ -40,7 +40,7 @@
     </style>
 
     <style name="PhotoPaymentButtonStyle" parent="Widget.Material3.Button">
-        <item name="cornerRadius">8dp</item>
+        <item name="cornerRadius">4dp</item>
         <item name="backgroundTint">@color/gc_light_04</item>
         <item name="android:textColor">@color/gc_dark_01</item>
         <item name="android:textSize">17sp</item>

diff --git a/capture-sdk/sdk/src/main/res/values/dimens.xml b/capture-sdk/sdk/src/main/res/values/dimens.xml
@@ -3,7 +3,6 @@
     <dimen name="gc_medium">8dp</dimen>
     <dimen name="gc_medium_12">12dp</dimen>
     <dimen name="gc_large">16dp</dimen>
-    <dimen name="gc_large_20">16dp</dimen>
     <dimen name="gc_large_24">24dp</dimen>
     <dimen name="gc_large_32">32dp</dimen>
     <dimen name="gc_large_48">48dp</dimen>