Skip to content

Commit

Permalink
Merge pull request #507 from gini/PM-66_Remove-white-spaces-from-the-…
Browse files Browse the repository at this point in the history
…Error-Screen

fix(capture-sdk): Remove white spaces on error screen
  • Loading branch information
GeraltRiv authored Jul 30, 2024
2 parents 17beca7 + 2d33e33 commit a65caff
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,24 @@
android:alpha="0.15"
android:background="@color/gc_error_01"/>

<RelativeLayout
<LinearLayout
android:id="@+id/gc_error_header_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:layout_constraintTop_toBottomOf="@id/gc_injected_navigation_bar_container_top"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
android:layout_alignParentTop="true"
android:orientation="horizontal"
android:layout_marginTop="@dimen/gc_large"
android:minHeight="@dimen/gc_large_64"
android:paddingStart="@dimen/gc_large_24"
android:paddingEnd="@dimen/gc_large_24">
android:minHeight="@dimen/gc_large_42"
android:paddingStart="@dimen/gc_large_48"
android:paddingEnd="@dimen/gc_large_48">

<ImageView
android:id="@+id/gc_error_header_icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_height="match_parent"
android:layout_centerVertical="true"
android:layout_toStartOf="@id/gc_error_header"
android:layout_marginEnd="@dimen/gc_large_24"
Expand All @@ -51,22 +52,21 @@
android:id="@+id/gc_error_header"
style="@style/GiniCaptureTheme.Typography.Body2"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerInParent="true"
android:layout_height="match_parent"
android:gravity="center"
android:text="@string/gc_error_upload_title" />
</RelativeLayout>
</LinearLayout>

<TextView
android:id="@+id/gc_error_textview"
style="@style/GiniCaptureTheme.Typography.Body2"
android:layout_width="@dimen/gc_tablet_width"
android:layout_width="0dp"
android:layout_height="0dp"
android:layout_marginTop="@dimen/gc_large_24"
android:textColor="@color/gc_dark_06"
android:text="@string/gc_error_upload_text"
android:layout_marginStart="@dimen/gc_large_24"
android:layout_marginEnd="@dimen/gc_large_24"
android:layout_marginStart="@dimen/gc_large_48"
android:layout_marginEnd="@dimen/gc_large_48"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintBottom_toTopOf="@id/gc_error_button_container"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,24 @@
android:alpha="0.15"
android:background="@color/gc_error_01"/>

<RelativeLayout
<LinearLayout
android:id="@+id/gc_error_header_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:layout_constraintTop_toBottomOf="@id/gc_injected_navigation_bar_container_top"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
android:layout_alignParentTop="true"
android:orientation="horizontal"
android:layout_marginTop="@dimen/gc_large"
android:minHeight="@dimen/gc_large_64"
android:paddingStart="@dimen/gc_large_24"
android:paddingEnd="@dimen/gc_large_24">
android:minHeight="@dimen/gc_large_42"
android:paddingStart="@dimen/gc_large_48"
android:paddingEnd="@dimen/gc_large_48">

<ImageView
android:id="@+id/gc_error_header_icon"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_height="match_parent"
android:layout_centerVertical="true"
android:layout_toStartOf="@id/gc_error_header"
android:layout_marginEnd="@dimen/gc_large_24"
Expand All @@ -51,11 +52,10 @@
android:id="@+id/gc_error_header"
style="@style/GiniCaptureTheme.Typography.Body2"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerInParent="true"
android:layout_height="match_parent"
android:gravity="center"
android:text="@string/gc_error_upload_title" />
</RelativeLayout>
</LinearLayout>

<TextView
android:id="@+id/gc_error_textview"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<dimen name="gc_large_20">20dp</dimen>
<dimen name="gc_large_24">24dp</dimen>
<dimen name="gc_large_32">32dp</dimen>
<dimen name="gc_large_42">52dp</dimen>
<dimen name="gc_large_48">64dp</dimen>
<dimen name="gc_large_64">80dp</dimen>
<dimen name="gc_large_80">96dp</dimen>
Expand Down
1 change: 1 addition & 0 deletions capture-sdk/sdk/src/main/res/values-sw600dp/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<dimen name="gc_large_20">20dp</dimen>
<dimen name="gc_large_24">24dp</dimen>
<dimen name="gc_large_32">32dp</dimen>
<dimen name="gc_large_42">52dp</dimen>
<dimen name="gc_large_48">64dp</dimen>
<dimen name="gc_large_64">80dp</dimen>
<dimen name="gc_large_80">96dp</dimen>
Expand Down
1 change: 1 addition & 0 deletions capture-sdk/sdk/src/main/res/values/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<dimen name="gc_large_20">20dp</dimen>
<dimen name="gc_large_24">24dp</dimen>
<dimen name="gc_large_32">32dp</dimen>
<dimen name="gc_large_42">42dp</dimen>
<dimen name="gc_large_48">48dp</dimen>
<dimen name="gc_large_64">64dp</dimen>
<dimen name="gc_large_80">80dp</dimen>
Expand Down

0 comments on commit a65caff

Please sign in to comment.