Change METADATA-VERSION.txt to METADATA-VERSION.php

Prevents people loading the txt file in the vendor directory to see which version of the library is in use.
giggsey · Apr 29, 2024 · 22f807e · 22f807e
1 parent 040824f
commit 22f807e
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 15 deletions.
diff --git a/LICENSE → LICENSE.txt b/LICENSE → LICENSE.txt
diff --git a/METADATA-VERSION.php b/METADATA-VERSION.php
@@ -0,0 +1,8 @@
+<?php
+/**
+ * This file specifies the revision of the metadata to build from.
+ * It can be a commit, branch or tag of the https://github.com/google/libphonenumber project
+ * For more information, look at the phing tasks in build.xml
+ * @internal
+ */
+return 'v8.13.35';
diff --git a/METADATA-VERSION.txt b/METADATA-VERSION.txt
diff --git a/README.md b/README.md
@@ -143,4 +143,4 @@ If you do need to generate the data, the commands are provided by [Phing](https:
 $ vendor/bin/phing compile
 ```
 
-This compile process clones the [libphonenumber](https://github.com/google/libphonenumber) project at the version specified in [METADATA-VERSION.txt](METADATA-VERSION.txt).
+This compile task clones the [libphonenumber](https://github.com/google/libphonenumber) project at the version specified in [METADATA-VERSION.php](METADATA-VERSION.php).
diff --git a/build.xml b/build.xml
@@ -6,15 +6,7 @@
     <property name="git.url" value="https://github.com/google/libphonenumber.git"/>
     <property name="git.path" value="libphonenumber-data-dir"/>
 
-    <loadfile property="metadata.version" file="METADATA-VERSION.txt">
-        <filterchain>
-            <striplinecomments>
-                <comment value="#" />
-            </striplinecomments>
-            <striplinebreaks />
-        </filterchain>
-    </loadfile>
-
+    <php returnProperty="metadata.version" expression="require 'METADATA-VERSION.php';" />
     <property name="data.testCoreData" value="tests/core/data/"/>
     <property name="data.coreData" value="src/data/"/>