Allowed labels for cronjobs, jobs, and changelog. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Strigix have you tested it ? |
|
Not yet. |
|
Well i'm in a pickle. Is that for MCs or WCs as well? |
|
Oh, that was quite the late answer. |
|
Then I would suggest you add it here https://github.com/giantswarm/config/blob/main/default/apps/observability-bundle/configmap-values.yaml.template instead like https://github.com/giantswarm/config/pull/2047 but beware this was not tested, you might want to test this config |
|
Maybe we still need this here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/giantswarm/giantswarm/issues/28422