-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the max buffersize for jsoniter #2459
Set the max buffersize for jsoniter #2459
Conversation
adapters/quick/src/main/scala/caliban/QuickRequestHandler.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add a test case in TapirAdapterSpec
that would fail using the pre-PR code? That way we can ensure that the implicits are all properly used across all adapters.
adapters/quick/src/main/scala/caliban/QuickRequestHandler.scala
Outdated
Show resolved
Hide resolved
adapters/quick/src/main/scala/caliban/QuickRequestHandler.scala
Outdated
Show resolved
Hide resolved
adapters/quick/src/main/scala/caliban/QuickRequestHandler.scala
Outdated
Show resolved
Hide resolved
047afa9
to
c90df59
Compare
c6db04d
to
f3bd899
Compare
I added a test case, but it currently also fails on this branch -- we're getting |
f3bd899
to
50055c8
Compare
50055c8
to
68361a0
Compare
@ghostdogpr want to take a new look? There's a test case that fails on main and works on the branch now. I tried to avoid using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a first take on #2458
Let me know if there's something missing, or if I should try another way to do this.