Delete deprecated rendering class #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpdaniels
force-pushed
the
delete-deprecated-rendering
branch
from
6c03142 to
4014a13
Compare
ghostdogpr
approved these changes
Jun 1, 2024
ghostdogpr
added a commit
that referenced
this pull request
Jun 2, 2024
This reverts commit 8b0305f.
ghostdogpr
added a commit
that referenced
this pull request
Jun 2, 2024
|
@paulpdaniels ah sorry, I merged it then reverted it because I am going to do a minor release and I think it's better to include this the next major instead. Could you reopen it? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class has been deprecated since 2.3.1, I think we can safely delete it now.