-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @oneOf
inputs
#1846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Aug 21, 2023
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
kyri-petrou
commented
Aug 21, 2023
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
kyri-petrou
commented
Aug 21, 2023
# Conflicts: # core/src/test/scala/caliban/RenderingSpec.scala
ghostdogpr
reviewed
Aug 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
kyri-petrou
commented
Aug 29, 2023
# Conflicts: # core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala # core/src/main/scala-3/caliban/schema/ArgBuilderDerivation.scala # core/src/main/scala/caliban/rendering/DocumentRenderer.scala # core/src/main/scala/caliban/validation/Validator.scala # core/src/test/scala/caliban/RenderingSpec.scala
# Conflicts: # build.sbt # core/src/main/scala-2/caliban/schema/SchemaDerivation.scala # core/src/main/scala-3/caliban/schema/SchemaDerivation.scala # core/src/main/scala-3/caliban/schema/macros/Macros.scala # core/src/main/scala/caliban/introspection/Introspector.scala # core/src/main/scala/caliban/introspection/adt/__InputValue.scala # core/src/main/scala/caliban/introspection/adt/__Type.scala # core/src/main/scala/caliban/schema/Schema.scala # core/src/main/scala/caliban/validation/Validator.scala # core/src/test/scala/caliban/introspection/IntrospectionSpec.scala
kyri-petrou
added
the
breaking change
The PR contains binary incompatible changes
label
Nov 19, 2023
paulpdaniels
reviewed
Jun 3, 2024
core/src/main/scala-2/caliban/schema/ArgBuilderDerivation.scala
Outdated
Show resolved
Hide resolved
paulpdaniels
reviewed
Jun 4, 2024
paulpdaniels
approved these changes
Jun 4, 2024
# Conflicts: # build.sbt # core/src/main/scala-3/caliban/schema/DerivationUtils.scala
ghostdogpr
reviewed
Jun 17, 2024
ghostdogpr
approved these changes
Jun 18, 2024
🚀 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERY early draft for adding support for the
@oneOf
inputs, just to discuss whether we're on the right track. See current version of the RFC hereSome of the assumptions I made:
oneOf
. I think that makes sense since the spec on@oneOf
is very strict, so it's very unlikely that these sealed traits will be used for any return types@oneOf
via macros. I think it's nicer UX if we give compile-time errors instead of runtime ones for invalid types. However, in Scala 2 we don't control the derivation so we have to enforce these checks during runtime. I understand if we want to unify the validation, so I'm happy to remove the macros@oneOf
if they have only 1 field (kind of defeats the purpose?)TODO:
@oneOf
inputs inValidator
(both against the Schema & user inputs)@oneOf
inputs are a mix of input objects and Scalars