add mod_imjournal to rsyslog.conf #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -64,6 +64,8 @@ | |||
| $umask = undef, | |||
| $file_create_mode = '0644', | |||
| $dir_create_mode = '0700', | |||
| $working_directory = '/var/lib/rsyslog', | |||
There was a problem hiding this comment.
Could you rename to this work_directory so it matches the configuration option
|
Hi @joshuabaird looks good though we need the additional params to be documented in the README and for spec tests to be added. |
|
I would REALLY appreciate a hand with updating the spec tests for this one. I'm not quite sure where to place them and what exactly should be tested here. My spec test-fu is weak :( |
|
@joshuabaird squashed your commits and added tests and some small tweaks in PR #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For EL7, the
imjournalmodule should be loaded in rsyslog.conf.