Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load /etc/rsyslog.d/ config before main log entries #88

Merged
merged 1 commit into from
Nov 26, 2015
Merged

Load /etc/rsyslog.d/ config before main log entries #88

merged 1 commit into from
Nov 26, 2015

Conversation

NissesSenap
Copy link

Load config from /etc/rsyslog.d/*.conf before applying the main log
entries. This allows for overriding a sub-set of the default log entries
without having to redefine the whole log_entries array.

@anders-larsson
Copy link
Contributor

Hi,

Your pull request is failing because of Puppet version 4.3 handles versioncmp() differently. It's probably not related to your pull request. See last comments in #77.

Load config from /etc/rsyslog.d/*.conf before applying the main log
entries. This allows for overriding a sub-set of the default log entries
without having to redefine the whole log_entries array.
@Phil-Friderici
Copy link
Contributor

should be fixed since v0.20.2 containes the fix for versioncmp() :)

@ghoneycutt
Copy link
Owner

@anders-larsson or @Phil-Friderici does this look good to merge?

I look to either of you to give me a +1 before I merge with this module. If you are a submitting the PR, then the other needs to be the reviewer.

@anders-larsson
Copy link
Contributor

@ghoneycutt +1.
I've tested these changes on RHEL7 and SLES11.4 and it works nicely.

ghoneycutt added a commit that referenced this pull request Nov 26, 2015
Load /etc/rsyslog.d/ config before main log entries
@ghoneycutt ghoneycutt merged commit e8990f6 into ghoneycutt:master Nov 26, 2015
@ghoneycutt
Copy link
Owner

Thanks everyone!

Released in v0.20.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants