Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec tests #128

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Fix spec tests #128

merged 3 commits into from
Jul 19, 2021

Conversation

Phil-Friderici
Copy link
Contributor

@Phil-Friderici Phil-Friderici commented Jul 19, 2021

This patch does stop testing Puppet 3 on Ruby versions prior to 2.1.9.
Ruby 1.8.7 seems to be unsupported by Travis these days :(
Ruby 1.9.3/2.0.0 and puppet-lint do produce conflicting error messages regarding absolute and relative naming of classes.

Beside the above mentioned, there had been only minor changes to the tests.

Phil Friderici added 3 commits July 19, 2021 14:46
- stop updating Ruby Gems on Puppet 3 & 4, it fails.
- stop testing Ruby versions older than 2.1.9
- pin several Ruby Gems for old Puppet version.
@ghoneycutt
Copy link
Owner

Thanks @Phil-Friderici !

@ghoneycutt ghoneycutt merged commit cb682d4 into ghoneycutt:master Jul 19, 2021
@Phil-Friderici Phil-Friderici deleted the fix_spec_tests branch July 20, 2021 07:45
@Phil-Friderici
Copy link
Contributor Author

Thanks @ghoneycutt :)
I am working on adding support for Suse 15 and EL8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants