Allow logserver entries to include port numbers, with log_server_port only used if a port isn't specified. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -345,14 +345,14 @@ _OR_ | |||
| <pre> | |||
| rsyslog::log_server: | |||
| - 'log1' | |||
| - 'log2' | |||
| - 'log2:1514' | |||
There was a problem hiding this comment.
Add an explanation for this in the message above on line 338
There was a problem hiding this comment.
Heh, that was a typo anyway, it should have been log3 - implying a third log server destination using a non-default port.
|
Looks good, though we'll need some spec tests. |
|
I'll try to add spec tests in the next day or so. |
|
Clarified README and added spec test for log_server entries with port numbers. |
|
This is failing because of updates to some gem's.. I'll take a look |
|
Created PR #116 to fix travis |
|
Please rebase against master to pick up my changes that will fix travis and squash your commits. |
|
Sorry, I failed at rebasing. Had a bad day. ;) All done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.