-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missingok to rsyslog logrorate (RHEL default) #113
base: master
Are you sure you want to change the base?
Conversation
I don't understand why it's failing in Solaris rsyslog conf. I have only modified the RedHat one. |
@@ -430,6 +430,7 @@ | |||
'/var/log/cron', | |||
] | |||
$default_logrotate_options = [ | |||
'missingok', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section is 'RedHat', default: {
so it applies to RedHat and everything that is not explicitly called out above (Suse and Debian).
Does logrotate on EL5 support missingok ? |
The EL5 is already end of life and should not be supported. Probably there is anyone who uses your module on that operating system version. According to Google, the default logrotate configuration on EL5 has the missingok option. I'll have a look again at the code. I thought that default was included in the RedHat section. |
RedHat and the defaults are the same, which would mean Solaris. We would have to check with Solaris systems to ensure it is OK. |
Many large institutions that use this code rely on it supporting EL 5, so we cannot just drop it. |
From what I know, Solaris does not have logrotate, but logadm. You can by installing a third-party package such as CSWlogrotate and that supports 'missingok'. Is that you were referring to ? |
No description provided.