Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missingok to rsyslog logrorate (RHEL default) #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gothicx
Copy link
Contributor

@gothicx gothicx commented May 26, 2016

No description provided.

@gothicx
Copy link
Contributor Author

gothicx commented May 27, 2016

I don't understand why it's failing in Solaris rsyslog conf. I have only modified the RedHat one.

@@ -430,6 +430,7 @@
'/var/log/cron',
]
$default_logrotate_options = [
'missingok',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section is 'RedHat', default: { so it applies to RedHat and everything that is not explicitly called out above (Suse and Debian).

@ghoneycutt
Copy link
Owner

Does logrotate on EL5 support missingok ?

@gothicx
Copy link
Contributor Author

gothicx commented May 27, 2016

The EL5 is already end of life and should not be supported. Probably there is anyone who uses your module on that operating system version. According to Google, the default logrotate configuration on EL5 has the missingok option.

I'll have a look again at the code. I thought that default was included in the RedHat section.

@ghoneycutt
Copy link
Owner

RedHat and the defaults are the same, which would mean Solaris. We would have to check with Solaris systems to ensure it is OK.

@ghoneycutt
Copy link
Owner

Many large institutions that use this code rely on it supporting EL 5, so we cannot just drop it.

@gothicx
Copy link
Contributor Author

gothicx commented Jun 2, 2016

From what I know, Solaris does not have logrotate, but logadm. You can by installing a third-party package such as CSWlogrotate and that supports 'missingok'. Is that you were referring to ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants