Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for gpm_api.io #8

Merged
merged 39 commits into from
Sep 6, 2023

Update gpm_api/tests/io/test_checks.py

03d7578
Select commit
Loading
Failed to load commit list.
Merged

Add unit tests for gpm_api.io #8

Update gpm_api/tests/io/test_checks.py
03d7578
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Sep 6, 2023 in 9s

4 issues found.

Annotations

Check notice on line 155 in gpm_api/tests/io/test_download.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

gpm_api/tests/io/test_download.py#L155

unresolved comment '# TODO: Assert username/password are passed to ftp_mock.login (assert_called_with not working?)' (C100)

Check notice on line 153 in gpm_api/tests/conftest.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

gpm_api/tests/conftest.py#L153

unresolved comment '# TODO: Add more products with varying attributes ...' (C100)

Check notice on line 198 in gpm_api/io/download.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

gpm_api/io/download.py#L198

unresolved comment '# TODO: maybe here capture (with -1) if the file does not exists !�' (C100)

Check notice on line 23 in gpm_api/tests/io/test_data_integrity.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

gpm_api/tests/io/test_data_integrity.py#L23

unresolved comment '# TODO: Test an actual HDF5 for OSError and empty list (success)' (C100)