ci : reduce severity of unused Pyright ignore comments #9697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
python
ggerganov
approved these changes
Sep 30, 2024
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pyrighttype check test otherwise fails because of unnecessary ignore comments (e.g. in #9694, even if unrelated). The capabilities of Pyright and/or type annotations of the Python dependencies of the convert scripts change over time. Since the "fix" to those warning doesn't really require code changes, I think it's more appropriate to not make them warnings (especially since thereportUnnecessaryTypeIgnoreCommentcheck isn't enabled by default).I've also updated the Pyright version used for the checks, and overriden the
disableBytesTypePromotionsoption because the default was changed in version1.1.378.