Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sycl: initial cmake support of SYCL for AMD GPUs #9658

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

Alcpz
Copy link
Collaborator

@Alcpz Alcpz commented Sep 26, 2024


The SYCL backend can be run in AMD GPUs as well as long as the sub_group_size (i.e. WARP_SIZE) is either 16 or 32.
This PR gives initial support to compile on AMD GPUs. Since the backend does not provide full support, I don't think it's good to update the documentation until it is improved.

@Alcpz
Copy link
Collaborator Author

Alcpz commented Sep 26, 2024

Copy link
Contributor

@OuadiElfarouki OuadiElfarouki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would only suggest to add a comment/description on the gfx/arch or devices tested. Thank you!

@joeatodd
Copy link
Contributor

joeatodd commented Oct 1, 2024

Looks good. Could we describe the AMD support in the SYCL README?

ggml/src/CMakeLists.txt Outdated Show resolved Hide resolved
@Alcpz Alcpz force-pushed the Alcpz/sycl-amd-support branch from 5d80dd5 to b435fc5 Compare October 1, 2024 14:37
@Alcpz
Copy link
Collaborator Author

Alcpz commented Oct 1, 2024

Looks good. Could we describe the AMD support in the SYCL README?

@joeatodd I´ve added the documentation for the backend.

@OuadiElfarouki OuadiElfarouki requested a review from airMeng October 1, 2024 14:38
@Alcpz Alcpz force-pushed the Alcpz/sycl-amd-support branch from b435fc5 to 0617335 Compare October 1, 2024 14:41
@github-actions github-actions bot added documentation Improvements or additions to documentation SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Oct 1, 2024
Copy link
Contributor

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs!

docs/backend/SYCL.md Outdated Show resolved Hide resolved
@OuadiElfarouki OuadiElfarouki merged commit f536f4c into ggerganov:master Oct 2, 2024
53 checks passed
@Alcpz Alcpz deleted the Alcpz/sycl-amd-support branch October 2, 2024 12:58
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
sycl: initial cmake support of SYCL for AMD GPUs
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
sycl: initial cmake support of SYCL for AMD GPUs
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
sycl: initial cmake support of SYCL for AMD GPUs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants