make sure params --split and --merge are not specified at same time in gguf-split

[kylo5aby]

• I have read the contributing guidelines
• Self-reported review complexity:
  • Low
  • Medium
  • High

[ggerganov]

These checks in the loop are hard to follow:

        if (is_op_set) {
            throw std::invalid_argument("error: either --split or --merge can be specified, but not both");
        }
        ...
        if (is_mode_set) {
            throw std::invalid_argument("error: either --split-max-tensors or --split-max-size can be specified, but not both");
        }

Seems something wrong with them already, or at the very least will cause trouble in the future if we add more args. Better to fix this properly.

[ngxson]

I'd suggest adding SPLIT_OP_NONE and enum split_mode for it (default to SPLIT_MODE_NONE).

will cause trouble in the future if we add more args.

For gguf-split, I don't think there will be many args added in the future, as this example is quite basic. This check is pretty much optional though, it's there for better user experience. One way is to remove it altogether if it causes trouble.

[kylo5aby]

I'd suggest adding SPLIT_OP_NONE and enum split_mode for it (default to SPLIT_MODE_NONE).

will cause trouble in the future if we add more args.

For gguf-split, I don't think there will be many args added in the future, as this example is quite basic. This check is pretty much optional though, it's there for better user experience. One way is to remove it altogether if it causes trouble.

yes, I think these enums will be helpful for handling repeated parameters, which is better for user experience