Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep the minimum min_keep value to 1 in sampling #9603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

keep the minimum min_keep value to 1 in sampling #9603

wants to merge 1 commit into from
+5 −4

Conversation

kylo5aby
Copy link
Contributor

@kylo5aby kylo5aby commented Sep 23, 2024 •
edited
Loading

Fixes #9587

@ggerganov
Copy link
Owner

I proposed an alternative fix in #9604. Think it solves the problem at a more fundamental level by fixing the min_keep logic in the tail-free sampler.

@davidrpugh davidrpugh mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: passing tfs_z crashes the server
2 participants
@kylo5aby @ggerganov