-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBM Granite Architecture #9412
Merged
Merged
IBM Granite Architecture #9412
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5ebc5ef
feat(gguf-py): Add Granite model and params to gguf-py
gabe-l-hart 406833d
feat(convert_hf_to_gguf): Add registration and param setup for Granite
gabe-l-hart 383065a
feat(llama.cpp): Add config parsing for Granite multiplier params
gabe-l-hart ec13f29
feat(llama.cpp): First pass at full port of granite deviations from l…
gabe-l-hart e73d795
fix(llama.cpp): Determine granite language 3b instruct by vocab size
gabe-l-hart 8086380
fix(convert_hf_to_gguf): Use LlamaModel as base for GraniteModel
gabe-l-hart 0bdf04e
fix(llama.cpp): Switch Granite param names to use _scale for consistency
gabe-l-hart 65c5bb9
fix(convert_hf_to_gguf/gguf-py): _multiplier -> _scale
gabe-l-hart 5d054a4
fix(llama.cpp): Use separate switch clause for granite in llm_load_hp…
gabe-l-hart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why
head_dim
should be actively removed (withpop
) when present instead of simply not requiring it.Is there a particular reason why this is done here? Does
head_dim
cause problems for Granite?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I'm not intimately familiar with why it was done this way, but in the
transformers
implementation, there is aValueError
raised ifhead_dim
is not directly computed fromnum_heads
andhidden_size
and it is not supported as a parameter to the model's config, so I put this here as a guard against an invalidconfig.json
that had it present.