-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py : fix requirements check '==' -> '~=' #8982
Conversation
examples/llava/requirements.txt
Outdated
@@ -2,4 +2,4 @@ | |||
--extra-index-url https://download.pytorch.org/whl/cpu | |||
pillow~=10.2.0 | |||
torch~=2.2.1 | |||
torchvision==0.17.1 | |||
torchvision!=0.17.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? I don't know what that syntax does in pip but it seems like it should be ~=
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, it was a mistake
It seems like the Maybe using the same glob pattern as in llama.cpp/scripts/check-requirements.sh Line 142 in 8cd1bcf
(and adapting it to conform to GitHub's file path pattern syntax) diff --git a/.github/workflows/python-check-requirements.yml b/.github/workflows/python-check-requirements.yml
index 4e0374fc..46e80aec 100644
--- a/.github/workflows/python-check-requirements.yml
+++ b/.github/workflows/python-check-requirements.yml
@@ -6,15 +6,13 @@ on:
- '.github/workflows/python-check-requirements.yml'
- 'scripts/check-requirements.sh'
- 'convert*.py'
- - 'requirements.txt'
- - 'requirements/*.txt'
+ - '**/requirements*.txt'
pull_request:
paths:
- '.github/workflows/python-check-requirements.yml'
- 'scripts/check-requirements.sh'
- 'convert*.py'
- - 'requirements.txt'
- - 'requirements/*.txt'
+ - '**/requirements*.txt'
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }} |
* py : fix requirements check '==' -> '~=' * cont : fix the fix * ci : run on all requirements.txt
* py : fix requirements check '==' -> '~=' * cont : fix the fix * ci : run on all requirements.txt
ref #7599 (comment)