Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py : switch to snake_case #8305

Merged
merged 6 commits into from
Jul 5, 2024
Merged

py : switch to snake_case #8305

merged 6 commits into from
Jul 5, 2024

Conversation

ggerganov
Copy link
Owner

cont #5745

Use snake_case for all Python filenames

compilade
compilade reviewed Jul 4, 2024
View reviewed changes
convert_hf_to_gguf.py Outdated Show resolved Hide resolved
convert_hf_to_gguf_update.py Outdated Show resolved Hide resolved
docs/HOWTO-add-model.md Outdated Show resolved Hide resolved
@ggerganov
cont
c172b32 
ggml-ci
@github-actions github-actions bot added documentation Improvements or additions to documentation script Script related examples python python script changes devops improvements to build systems and github actions labels Jul 4, 2024
@ggerganov ggerganov requested a review from compilade July 4, 2024 19:37
compilade
compilade approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pretty much all occurrences have been found and replaced, but let's wait for CI (especially check-requirements).

ditsuke
ditsuke approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@ditsuke ditsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All occurrences have been covered afaict, CI passes too now.

@ggerganov ggerganov merged commit e235b26 into master Jul 5, 2024
10 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 7, 2024
@ggerganov @compilade
py : switch to snake_case (ggerganov#8305)
c5009e6 
* py : switch to snake_case

ggml-ci

* cont

ggml-ci

* cont

ggml-ci

* cont : fix link

* gguf-py : use snake_case in scripts entrypoint export

* py : rename requirements for convert_legacy_llama.py

Needed for scripts/check-requirements.sh

---------

Co-authored-by: Francis Couture-Harpin <[email protected]>
This was referenced Jul 9, 2024
Open
Open
teleprint-me added a commit to teleprint-me/llama.cpp that referenced this pull request Jul 14, 2024
@teleprint-me
chore : Apply snake case as described in ggerganov#8305
4204cab 
Signed-off-by: teleprint-me <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compilade compilade compilade approved these changes

@ditsuke ditsuke ditsuke approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions documentation Improvements or additions to documentation examples python python script changes script Script related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggerganov @ditsuke @compilade