-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(convert-hf-to-gguf): requires einops for InternLM2ForCausalLM models #5792
Conversation
@crasm Were these files meant to contain required dependencies, or also include optional dependencies? In the latter case, this PR is a step in the right direction, but we also need to add tiktoken for Qwen models. |
good point. imho they are so tiny compared to the rest, that we could just add them before building workarounds for containers |
It's supposed to be for all dependencies. The check-requirements.sh script and workflow were intended to prevent these kinds of PRs from being necessary, by forcing all dependencies to be declared in the requirements.txt files.
|
Maybe it'd be better to forgo the complexity I introduced in the requirements.txt. We could just do #5745 and declare each script's optional dependencies in the pyproject.toml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is an improvement, and is fine by me until we have a better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll investigate the disk space issue, which I suspect is a configuration issue rather than an actual resource limitation.
I'm trying to figure out how to catch any more of these implicit dependencies to prevent more gotchas. @cebtenzzre Is it normal to have import statements embedded in various places in python scripts? That seems crazy to me coming from other languages. |
Yep, this is how optional dependencies are typically implemented in python - you import them lazily so they only matter if the code that needs them is run. With a venv and a type checker like mypy, it's not hard to detect if these dependencies are missing when they shouldn't be - it will complain with |
small fix for container images, which will currently fail with:
used 0.7.0 cause it's the current release.