Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support loading vocab from fast tokenizer config in convert.py #3633
support loading vocab from fast tokenizer config in convert.py #3633
Changes from 10 commits
f7e377d
b0e00cb
f888d2e
ea9f35f
c7b636e
6ec856b
1f16e5f
e876aec
1778450
a5b26b6
5a1f178
89611cb
97f690a
e715442
d54764d
e19b780
28f09be
4adb8b9
13f0701
f37a7d7
9f4dc23
dcf372e
cc1f3fc
026eb7c
2e263ca
5ac1949
74d80a8
61edd1b
1f5357c
8fabb01
c3b1c12
35e95b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are not returning a boolean value in this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the one you pointed out. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llama.cpp/convert.py
Lines 1082 to 1101 in 8e672ef
It seems like a good idea to keep the names of the variables the same as they are in the main branch.
I like your suggestion for the function name, so I'll incorporate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand why you removed *.safetensors?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model files are automatically discovered. The model file names are arbitrary, some are split and others are not. The model files are dynamically "lazy" loaded to save memory as a result.
https://github.com/ggerganov/llama.cpp/blob/master/convert.py#L1348
The vocab can be set manually though.
https://github.com/ggerganov/llama.cpp/blob/master/convert.py#L1461
Not sure if that answers your question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you removed this argument in this PR, I think you better update the README.md file as well.