Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYCL: Use get_multi_ptr instead of deprecated get_pointer in wkv6 #11087

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

qnixsynapse
Copy link
Contributor

According to the SYCL reference, the member function get_pointer of the sycl::local_accessor class has been deprecated in SYCL 2020. This is a one line patch to use get_multi_ptr instead to remove the warning.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Jan 5, 2025
@NeoZhangJianyu
Copy link
Collaborator

It's good to update the code!

I have a small comment:
Is it possible to keep the original code format (multiple lines)? So that it's easy to know the changed code, like

shared_mem_acc.get_pointer()
to
(float*)shared_mem_acc.get_multi_ptr<sycl::access::decorated::no>().get()

@qnixsynapse
Copy link
Contributor Author

@NeoZhangJianyu Yes sure. It's my editor's "autoformatter" that does it whenever I edit code. I updated the change.

@NeoZhangJianyu NeoZhangJianyu merged commit c0d6f79 into ggerganov:master Jan 7, 2025
48 checks passed
@qnixsynapse qnixsynapse deleted the multi_pointer branch January 7, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants