Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rwkv chat template fix #10001

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Rwkv chat template fix #10001

merged 3 commits into from
Oct 22, 2024

Conversation

MollySophia
Copy link
Contributor

  • Removed useless template matching for rwkv-world since there actually isn't a template to match, which may also cause issues for other models, as per the conversation in Add chat template for RWKV-World #9968.
  • Added a comment about the EOT token hack for current RWKV models.

Thanks to @ngxson

@github-actions github-actions bot added testing Everything test related python python script changes labels Oct 22, 2024
ngxson
ngxson reviewed Oct 22, 2024
View reviewed changes
src/llama.cpp Show resolved Hide resolved
@MollySophia @ngxson
Update src/llama.cpp
1135b0f 
Co-authored-by: Xuan Son Nguyen <[email protected]>
@ngxson ngxson merged commit 11d4705 into ggerganov:master Oct 22, 2024
54 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@MollySophia @ngxson @dsx1986
Rwkv chat template fix (ggerganov#10001)
4aff93e 
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@MollySophia @ngxson @dsx1986
Rwkv chat template fix (ggerganov#10001)
b8ba24b 
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@MollySophia @ngxson @arthw
Rwkv chat template fix (ggerganov#10001)
9177ad4 
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@MollySophia @ngxson @arthw
Rwkv chat template fix (ggerganov#10001)
1c822cb 
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson approved these changes

Assignees
No one assigned
Labels
python python script changes testing Everything test related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MollySophia @ngxson