Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-2309: [MB] The biometric_consent_flow is EARLY not EAGER #469

Merged
merged 1 commit into from
Sep 25, 2024
Merged

SDK-2309: [MB] The biometric_consent_flow is EARLY not EAGER #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yoti-sdk-api/src/main/java/com/yoti/api/client/docs/DocScanConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ private DocScanConstants() { }

public static final String GBP = "GBP";

public static final String EAGER = "EAGER";
public static final String EARLY = "EARLY";
public static final String JUST_IN_TIME = "JUST_IN_TIME";

public static final String ON = "ON";
Expand Down
14 changes: 7 additions & 7 deletions yoti-sdk-api/src/main/java/com/yoti/api/client/docs/session/create/SdkConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ public Builder withAllowHandoff(boolean allowHandoff) {
}

/**
* Sets the {@link AttemptsConfiguration} for the session
* Sets the {@link AttemptsConfiguration} for any Text Extractions Tasks
*
* @param attemptsConfiguration the configuration for retries
* @return the builder
Expand All @@ -437,7 +437,7 @@ public Builder withAttemptsConfiguration(AttemptsConfiguration attemptsConfigura
}

/**
* Sets the brand ID to be used for the session
* Sets the brand ID used for customising the UI
*
* @param brandId the brand ID
* @return the builder
Expand All @@ -448,7 +448,7 @@ public Builder withBrandId(String brandId) {
}

/**
* Sets the Biometric Consent Flow for the session
* Sets the Biometric Consent Flow to be applied in the UI
*
* @param biometricConsentFlow the biometric consent flow
* @return the builder
Expand All @@ -459,16 +459,16 @@ public Builder withBiometricConsentFlow(String biometricConsentFlow) {
}

/**
* Sets the biometric consent flow to EAGER for the session
* Sets the biometric consent flow to EARLY
*
* @return the builder
*/
public Builder withBiometricConsentFlowEager() {
return withBiometricConsentFlow(DocScanConstants.EAGER);
public Builder withBiometricConsentFlowEarly() {
return withBiometricConsentFlow(DocScanConstants.EARLY);
}

/**
* Sets the biometric consent flow to JUST_IN_TIME for the session
* Sets the biometric consent flow to JUST_IN_TIME
*
* @return the builder
*/
Expand Down
6 changes: 3 additions & 3 deletions yoti-sdk-api/src/test/java/com/yoti/api/client/docs/session/create/SdkConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ public void shouldBuildSimpleSdkConfigWithCameraAndUpload() {
}

@Test
public void shouldBuildSimpleSdkConfigWithBiometricConsentFlowEager() {
public void shouldBuildSimpleSdkConfigWithBiometricConsentFlowEarly() {
SdkConfig result = SdkConfig.builder()
.withBiometricConsentFlowEager()
.withBiometricConsentFlowEarly()
.build();

assertThat(result.getBiometricConsentFlow(), is("EAGER"));
assertThat(result.getBiometricConsentFlow(), is("EARLY"));
}

@Test
Expand Down