SDK-2352: Enhanced error reason

[irotech]

No description provided.

[pn-santos]

This looks like what the implementation fo toString() should look like... as in:

Optional.ofNullable(profile.getError())
    .map(ErrorDetails::toString)
    .orElse("")

[pn-santos]

No need to create an ObjectMapper instance every time we de-serialize a JSON. Make it a constant (maybe even a "global" constant if it's important to enforce the same config wherever it is used).

[pn-santos]

Usually an exception message will say:

• What failed
• Why it failed
• (optional) what it would take to not fail

So something like:

String.format("Failed to parse failure receipt error reason: '%s'", e.getMessage())

Additionally it's not a very good practice to swallow exceptions like this. Either pass the exception as a cause or include the message of the exception when creating the message for the exception that will be (re)thrown.
(a third option would be to log the stack trace and not propagate the cause, however it would require a logging framework which I don't know if this has)

When it comes to including the message it might also be useful to include every message along the exception chain (in case there's more than one cause) along the lines of:

<ex msg>: <msg of cause of ex>: <msg of cause of cause of ex>

(this comment applies elsewhere where the same pattern exists)

[irotech]

I ended up creating an exception for it

[pn-santos]

Avoid calling methods within a class that will only access member variables. Whenever you need to use a member var just use the member var:

return error != null

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

34.4% Coverage
0.0% Duplication