Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-2230: Expose share v2 API #413

Merged
merged 18 commits into from
Oct 6, 2023
Merged

SDK-2230: Expose share v2 API #413

merged 18 commits into from
Oct 6, 2023

Conversation

irotech
Copy link
Collaborator

@irotech irotech commented Jul 25, 2023 •
edited
Loading

  • Add support to Share V2

@irotech irotech mentioned this pull request Jul 25, 2023
Closed
pn-santos
pn-santos approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@pn-santos pn-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nits/questions

yoti-sdk-api/src/main/java/com/yoti/api/client/identity/policy/Policy.java Outdated Show resolved Hide resolved
yoti-sdk-api/src/main/java/com/yoti/api/client/identity/policy/Policy.java Outdated Show resolved Hide resolved
...rc/main/java/com/yoti/api/client/identity/extension/ThirdPartyAttributeExtensionBuilder.java Outdated Show resolved Hide resolved
yoti-sdk-api/src/main/java/com/yoti/api/client/DigitalIdentityClient.java Outdated Show resolved Hide resolved
yoti-sdk-api/src/main/java/com/yoti/api/client/DigitalIdentityClient.java Outdated Show resolved Hide resolved
@irotech irotech requested a review from pn-santos August 1, 2023 11:19
pn-santos
pn-santos approved these changes Aug 1, 2023
View reviewed changes
yoti-sdk-api/src/main/java/com/yoti/api/client/identity/policy/Policy.java Outdated
return this;
}

if (constraintsNotPresent(wanted.getConstraints())) {
Copy link
Collaborator

@pn-santos pn-santos Aug 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasNoConstraints (it's preferable, if feasible, for boolean returning methods to use is or has type prefixes).

Also AFAICT this method is checking whether there's constraints in wantedAttributes that are not equal to those in wanted right? (true if there aren't, false if there are)

So maybe this method would be clearer if it was something like:

if (hasIdenticalConstraints(wantedAttributes, wanted))

(turning it into a static method)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

43.1% 43.1% Coverage
9.0% 9.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@irotech irotech merged commit e1034b8 into DEVELOPMENT Oct 6, 2023
8 of 9 checks passed
@irotech irotech deleted the SDK-2230 branch October 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pn-santos pn-santos pn-santos approved these changes

@MrBurtyyy MrBurtyyy Awaiting requested review from MrBurtyyy

@bentaye bentaye Awaiting requested review from bentaye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irotech @pn-santos