feat(flutter): Add Flutter support #735
Conversation
# Conflicts: # CHANGELOG.md
|
@buenaflor Ready for the first review/feedback round :) |
| const { selectedProject, selfHosted, sentryUrl, authToken } = | ||
| await getOrAskForProjectData(options, 'flutter'); | ||
|
|
||
| // const dsn = selectedProject.keys[0].dsn.public; |
| ${chalk.greenBright('Successfully installed the Sentry Flutter SDK!')} | ||
|
|
||
| ${chalk.cyan( | ||
| `You can validate your setup by launching your application and checking Sentry issues page afterwards |
There was a problem hiding this comment.
Should it make sense to give more specific instructions? Since we set up the plugin as well the app should be able to have symbolicated stacktraces. Telling the user to start the app I assume most people will just run it in dev mode
There was a problem hiding this comment.
btw @denrase wizard filename is wrong -> wizzard
There was a problem hiding this comment.
Hey, leaving a first pass review for general wizard recommendations. This is not technical as I have very little to no context around Flutter.
- Ideally, we can make the SDK features selectable from the start as we've done recently with the JS-SDK wizards. See Make Sentry features selectable in wizard #558
- Great to see some tests for this flow! :) I recommend adding an e2e test app as well as this proved quite useful for our other wizards.
Feel free to disregard my advice as I'll happily leave the final call to the mobile team. Don't want to block you, just share some recommendations :)
There was a problem hiding this comment.
flutter-wizard.ts not flutter-wizzard.ts
just a typo
main.dartwith import, sentry setup and sample snippetpubspec.yamlwith sentry_flutter dependency and plugin to upload debug symbolsCloses getsentry/sentry-dart#2424