Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Automatically enable vercel cron monitors #507

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

AbhiPrasad
Copy link
Member

Given we are disabling the creation of vercel cron monitors by default getsentry/sentry-javascript#9697, let's update our onboarding to insert in automaticVercelMonitors as true.

Since this is being added during onboarding, we are being explicit about it being turned on. Users can easily remove this if they don't want this functionality.

@AbhiPrasad AbhiPrasad requested review from gaprl and lforst November 29, 2023 21:59
lforst
lforst previously approved these changes Nov 29, 2023
Copy link

github-actions bot commented Nov 29, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Automatically enable vercel cron monitors ([#507](https://github.com/getsentry/sentry-wizard/pull/507))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 6f4adf7

CHANGELOG.md Outdated
@@ -11,6 +11,7 @@
- feat(reactnative): Make `pod install` step optional (#501)
- feat(remix): Add Vite support (#495)
- feat(reactnative): Add Sentry Metro serializer (#502)
- feat(nextjs): Automatically enable vercel cron monitors (#507)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good bot

@lforst lforst dismissed their stale review November 30, 2023 09:59

this is wrong

@lforst lforst merged commit 40843c7 into master Nov 30, 2023
7 of 8 checks passed
@lforst lforst deleted the abhi-wizard-crons branch November 30, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants