Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Add instructions on how to add a global-error page to Next.js App Router #506

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 29, 2023

Adds instructions on how to add a global-error file to the App router for instrumentation.

@lforst lforst requested a review from Lms24 November 29, 2023 12:31
Copy link

github-actions bot commented Nov 29, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 766f2f7

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

);

clack.log.success(
`Created ${chalk.bold(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: should we use chalk.cyan here instead? I think we mostly use it when mentioning file names. But not sure how consistent we are with it in Nextjs, so feel free to disregard

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you're right. Will update.

@lforst lforst merged commit 249a0c5 into master Nov 29, 2023
10 checks passed
@lforst lforst deleted the lforst-next-global-error-page branch November 29, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants