-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for SOCKS5 proxy #1063
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
+ Coverage 82.38% 82.43% +0.04%
==========================================
Files 53 53
Lines 7751 7760 +9
Branches 1216 1215 -1
==========================================
+ Hits 6386 6397 +11
Misses 1253 1253
+ Partials 112 110 -2
|
|
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks! Just a few minor changes and questions.
# Conflicts: # CHANGELOG.md
(let's hope I didn't mess up CI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I know this was quite the odyssey, but the resulting integration tests alone are worth the pain ❤️.
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
…eat/socks5_proxy_joshua
Fixes #1030
Todo
-> currently checked for MacOS using Curl transport
-> using
mitmproxy
mitmproxy
-> replaced by adding it to
requirements.txt
-> especially about socks5 being circumvented if proxy is unavailable on mac
-> similar story on Windows with Autoproxy circumventing the proxy if a connection is possible
-> ❗️ this only manifested in the
capture
test, NOT in thecrash
test -> ToDo: reason about why crashpad doesn't autoproxy?-> document which transports/platforms don't support it (e.g. winhttp)