Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(replays): jemalloc and serde struct deserialization #1817

Closed
wants to merge 2 commits into from

Conversation

JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Feb 4, 2023

@JoshFerge JoshFerge marked this pull request as ready for review February 6, 2023 06:45
@JoshFerge JoshFerge requested review from a team and cmanallen February 6, 2023 06:45
@jan-auer
Copy link
Member

jan-auer commented Feb 6, 2023

Thank you for researching jemalloc! The changes you're listing here would be useful to run separately to see their individual impact, particularly:

  1. Swap the system memory allocator with jemalloc in default
  2. Then enable the background_thread flag to check for differences. The case mentioned in the linked issue where their application goes idle doesn't directly apply to us, but there could be a benefit. For that we'd need to understand better where the "leak" is coming from in the first place.
  3. Finally, re-introduce struct deserialization side-by-side with the current transcoder.

The jemalloc experiments can still make sense independently, but I would wait with 3 until we know that the transcoding approach does not work.

@jan-auer jan-auer marked this pull request as draft February 6, 2023 15:07
@jan-auer
Copy link
Member

jan-auer commented Feb 8, 2023

We'll eventually re-attempt jemalloc in isolation. Thanks for the work on this!

@jan-auer jan-auer closed this Feb 8, 2023
@jan-auer jan-auer deleted the jferg/jemalloc-canary-test branch February 8, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants