Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELBv2: register_targets() now validates that instances are running #8350

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #8286

@bblommers bblommers added this to the 5.0.22 milestone Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (147049e) to head (a7edd5b).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8350   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files        1159     1159           
  Lines      101119   101129   +10     
=======================================
+ Hits        95645    95655   +10     
  Misses       5474     5474           
Flag Coverage Δ
servertests 28.90% <35.00%> (+<0.01%) ⬆️
unittests 94.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 3eb9530 into getmoto:master Nov 30, 2024
53 checks passed
@bblommers bblommers deleted the elbv2-register-stopped-instance branch November 30, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elbv2 register_targets returning 200 when registering a stopped instance
1 participant