Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New make:language command #69

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

afbora
Copy link
Member

@afbora afbora commented Feb 24, 2024

No description provided.

@afbora afbora added the type: feature 🎉 Adds a feature (requests → feedback.getkirby.com) label Feb 24, 2024
@afbora afbora added this to the 1.4.0 milestone Feb 24, 2024
@afbora afbora requested a review from a team February 24, 2024 15:26
@afbora afbora self-assigned this Feb 24, 2024
@afbora afbora force-pushed the feature/make-language branch from a2b4b3c to c6841f5 Compare February 24, 2024 15:28
@afbora afbora force-pushed the feature/make-language branch from c6841f5 to cd3999e Compare February 26, 2024 09:02
@bastianallgeier
Copy link
Member

I wonder if we need to check for the languages option first. What happens if you add a language but the multi-language mode isn't activated?

@afbora
Copy link
Member Author

afbora commented Feb 27, 2024

Actually languages option only for panel. If there are language files in /site/languages directory, website works with multi-lang even languages => false option.

@bastianallgeier
Copy link
Member

@afbora haha, that's kind of embarrassing that I didn't know that.

@bastianallgeier bastianallgeier merged commit aa002f0 into develop Feb 27, 2024
10 checks passed
@bastianallgeier bastianallgeier deleted the feature/make-language branch February 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature 🎉 Adds a feature (requests → feedback.getkirby.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants