Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean:content command #55

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Conversation

distantnative
Copy link
Member

No description provided.

@distantnative distantnative added the type: feature 🎉 Adds a feature (requests → feedback.getkirby.com) label Nov 29, 2023
@distantnative distantnative self-assigned this Nov 29, 2023
commands/clean/content.php Outdated Show resolved Hide resolved
commands/clean/content.php Show resolved Hide resolved
@distantnative distantnative linked an issue Nov 29, 2023 that may be closed by this pull request
@bastianallgeier bastianallgeier force-pushed the feature/clean-content-command branch from c0d69e7 to c867877 Compare February 5, 2024 16:19
@bastianallgeier bastianallgeier marked this pull request as ready for review February 5, 2024 16:41
@bastianallgeier
Copy link
Member

I was wondering if we should put a warning before the command because it could be quite destructive.

@distantnative
Copy link
Member Author

@bastianallgeier makes sense. Maybe even where you have to type yes to continue, some other CLI scripts do that

@distantnative
Copy link
Member Author

👍 @bastianallgeier

@bastianallgeier bastianallgeier merged commit 679a616 into develop Feb 6, 2024
10 checks passed
@bastianallgeier bastianallgeier deleted the feature/clean-content-command branch February 6, 2024 09:21
@bastianallgeier bastianallgeier added this to the 1.3.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature 🎉 Adds a feature (requests → feedback.getkirby.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean:content command
2 participants