-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: multiple widgets per service #4338
Enhancement: multiple widgets per service #4338
Conversation
This should not be merged right now due to a security issue, will fix in a few minutes |
That commit should fix it up now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure how much testing you've done here, but this seems to break many widgets out of the box. I'm not sure why yet
e.g. using the exact same widget configs
- Multiple:
widgets:
- One:
type: unifi
...
- Two:
type: homebridge
...
- Unifi:
description: Unifi Console Management
widget:
type: unifi
...
- Homebridge:
description: HomeKit for the impatient
widget:
type: homebridge
...
I think I can see the issue, likely to do with how the proxying system works with having multiple widgets. Will check that now. |
Yup, those both have their own proxy handler which pulls the widget using |
Updated the fork, should fix those bugs with multiple widgets and some widgets not working |
Please see my changes:
Let me know if you note anything, probably should do more testing |
Yup, had a look at the changes. All seems good to me. In terms of testing, I do not have access to all of the services to test them individually, but I do agree that it should be put through more testing before merging. Not too sure how that testing should be done though. |
Proposed change
Allows for having multiple widgets per service. Syntax is as follows:
Closes #3024
Type of change
Checklist: